-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Introduction section #2725
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2725 +/- ##
=======================================
Coverage 65.86% 65.87%
=======================================
Files 233 233
Lines 17907 17904 -3
=======================================
- Hits 11795 11794 -1
+ Misses 6112 6110 -2 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@jaymedina - If you and Makayla are up for it, this maybe an easy PR to practice squashing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'd like to see the intro section beefed up a little bit more. Maybe briefly talk about the 3 different services offered: Observations (observations.py
), Catalogs (cutouts.py
) and Cutouts (cutouts.py
) and give a quick overview of their purpose based on what you read about them in the documentation. I'd also like to read a little bit more about MAST and what it offers to the astro community. You can use resources like this to help form your statements.
7e8da95
to
d4a39cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@bsipocz I think this is ready to merge, do I need to rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look all good @mstcyr2, thank you!
@mstcyr2 - I don't see a conflict, nor a code that could actually fail, so no need to rebase. Thanks for the squash and iterations! |
Adding introduction section to astroquery.mast docs.