-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New retrieval types for Gaia Datalink (GAIAPCR-1281 C9GACS-9070) #2775
New retrieval types for Gaia Datalink (GAIAPCR-1281 C9GACS-9070) #2775
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2775 +/- ##
==========================================
+ Coverage 66.09% 66.11% +0.02%
==========================================
Files 235 235
Lines 18071 18077 +6
==========================================
+ Hits 11944 11952 +8
+ Misses 6127 6125 -2
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@cosmoJFH - could you please provide more context and references? Are these already available with DR3 (as that is our default, and afaik the latest). |
…e documetation in the method.
Dear @bsipocz , for the Gaia FPR (Focused Product Release) that will be take place on the 10th of October 2023, the datatlink service needs to provide the new retrieval types
.These will also be needed for the the Gaia Data release 4 (https://www.cosmos.esa.int/web/gaia/release#:~:text=Gaia%20FPR%20(Focused%20Product%20Release)%2010%20October%202023&text=The%20first%20results%20of%20quasars,data%20for%20Long%20Period%20Variables.) This is the first change that we'd have to do in astroquery in order to provide access to the new products of datalink (https://www.cosmos.esa.int/web/gaia-users/archive/datalink-products). Not that although the new products associated to these retrieval types are not public yet, we need to have this change in place asap. |
Given that this doesn't seem to broke any current functionality, I will go ahead and merge it, I suppose while currently these don't do anything (and therefore it's not really the typical workflow to get it merged just yet), having compatibility in older versions with DR4 won't hurt. |
We include new retrieval types for data link that will be used in DR4: