-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
astroquery.mast : adding cloud support for Pan-STARRS mission #2893
Conversation
Hello @astrojimig! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-12-07 22:22:16 UTC |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2893 +/- ##
=======================================
Coverage 66.52% 66.52%
=======================================
Files 235 235
Lines 18101 18116 +15
=======================================
+ Hits 12041 12052 +11
- Misses 6060 6064 +4 ☔ View full report in Codecov by Sentry. |
@astrojimig - for fixing the linting I would suggest running the command locally rather than rely on CI, and then you could avoid the multiple linting fixing commits and iterations (could you squash them once all are fixed?). Besides that the PR looks to be in a really nice state, so this will be a rather quick review cycle. |
Thanks for the tip! And yes, I'll squash all the commits before I mark this as ready for review. |
decc4a0
to
f55f47b
Compare
Thanks! |
Thanks @astrojimig for your first astroquery PR. Looking forward for many more to come! |
This PR adds functionality to
astroquery.mast
to enable cloud data access for the Pan-STARRS mission data, which is now available via the MAST public S3 bucket (https://registry.opendata.aws/collab/stsci/)This is similar to #2261, which were the similar updates for GALEX mission that Jenny did last year.
Thank you!!