Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce running time for MAST doctests #3122

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

snbianco
Copy link
Contributor

@snbianco snbianco commented Oct 22, 2024

Adjusted some of the queries in MAST documentation to reduce the running time of the doctests. Reduced from ~9.5 minutes to ~3 minutes.

I also reformatted some of the queries to be more readable and updated outputs.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.49%. Comparing base (4e422d8) to head (701a4e3).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3122   +/-   ##
=======================================
  Coverage   67.49%   67.49%           
=======================================
  Files         233      233           
  Lines       18420    18420           
=======================================
  Hits        12433    12433           
  Misses       5987     5987           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snbianco snbianco marked this pull request as ready for review October 22, 2024 15:32
@snbianco snbianco requested a review from bsipocz October 22, 2024 15:32
@snbianco
Copy link
Contributor Author

@dr-rodriguez @astrojimig

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good, thanks for making the rearrangements to make these faster.

@bsipocz
Copy link
Member

bsipocz commented Oct 23, 2024

@snbianco - do I need to wait for sign-off from @dr-rodriguez or @astrojimig when you CC them, or that is more of a FYI shout out to them?

@bsipocz bsipocz linked an issue Oct 23, 2024 that may be closed by this pull request
@dr-rodriguez
Copy link

dr-rodriguez commented Oct 23, 2024

Sam let us know during our standup about this change so this is more of an FYI for us. Thanks!

@bsipocz bsipocz merged commit 147546c into astropy:main Oct 23, 2024
12 of 13 checks passed
@bsipocz
Copy link
Member

bsipocz commented Oct 23, 2024

Thanks Sam!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: restructure mast docs to be quicker
3 participants