Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3135 - TestEso.test_each_survey_and_SgrAstar fails #3136

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

juanmcloaiza
Copy link
Contributor

@juanmcloaiza juanmcloaiza commented Nov 22, 2024

Fix #3135 - TestEso.test_each_survey_and_SgrAstar fails

Changelog

  • Added ERIS-SPIFFIER to SGRA_SURVEYS

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.53%. Comparing base (ce16157) to head (26d3897).
Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3136      +/-   ##
==========================================
- Coverage   67.53%   67.53%   -0.01%     
==========================================
  Files         233      233              
  Lines       18487    18584      +97     
==========================================
+ Hits        12486    12551      +65     
- Misses       6001     6033      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bsipocz bsipocz added the eso label Nov 25, 2024
@bsipocz bsipocz added this to the v0.4.8 milestone Nov 25, 2024
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you very much!

However, test related changes doesn't need a changelog entry, so I'll remove all but the first commit before merging.

@bsipocz bsipocz merged commit 47f0eb0 into astropy:main Nov 25, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test TestEso.test_each_survey_and_SgrAstar fails
2 participants