Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to be consistent with v4 of algoliasearch #39

Merged
merged 7 commits into from
Oct 29, 2024
Merged

Update to be consistent with v4 of algoliasearch #39

merged 7 commits into from
Oct 29, 2024

Conversation

adrn
Copy link
Member

@adrn adrn commented Oct 11, 2024

This PR does a few things:

  • Switch from setuptools to pyproject.toml
  • Update the code that relies on algoliasearch to be compatible with v4 of that API
  • Simplifies some of the type checking thanks to the new requirement python>=3.11

@jeffjennings jeffjennings self-requested a review October 29, 2024 18:30
jeffjennings
jeffjennings approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@jeffjennings jeffjennings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great!

@jeffjennings jeffjennings merged commit a0bb8e8 into astropy:main Oct 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffjennings jeffjennings jeffjennings approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrn @jeffjennings