Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

Use tool:pytest instead of pytest #20

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Use tool:pytest instead of pytest #20

merged 1 commit into from
Jul 3, 2019

Conversation

scarabeusiv
Copy link
Contributor

Usage of only pytest is no longer working on pytest 4.2+

Usage of only pytest is no longer working on pytest 4.2+
@pllim pllim self-requested a review February 20, 2019 04:59
@pllim pllim requested a review from drdavella February 20, 2019 05:00
Copy link
Contributor

@drdavella drdavella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine with me, but if we do this I think we need to update the minimum required version of pytest as well (should be 3.1, I think). It may also require us to formally drop support for Py27, which shouldn't be a problem.

@scarabeusiv
Copy link
Contributor Author

You don't need to drop support for python 2.7, it just works there, I am applying this patch just to get the package buildable on python3.7 and python2.7 for openSUSE with pytest 4.2.

Also [tool:pytest] is supoorted since 3.0.0 pytest.

@blueyed
Copy link
Contributor

blueyed commented Mar 27, 2019

Older pytest would just ignore the section then, which is fine I guess?

It is not critical for using pytest-openfiles to have the config for when running its tests.

@blueyed
Copy link
Contributor

blueyed commented Mar 27, 2019

I think pytest itself should not error out, but use an existing "[tool:pytest]" section - so both could be given here then.

@bsipocz
Copy link
Member

bsipocz commented Jul 3, 2019

Based on the discussion above and the all green CI, I just go ahead and merge this.

@bsipocz bsipocz merged commit 49e6dfa into astropy:master Jul 3, 2019
astrofrog added a commit that referenced this pull request Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants