-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for APE 14 WCSes in find_optimal_celestial_wcs #334
Conversation
Codecov Report
@@ Coverage Diff @@
## main #334 +/- ##
==========================================
+ Coverage 93.58% 93.72% +0.14%
==========================================
Files 24 24
Lines 717 733 +16
==========================================
+ Hits 671 687 +16
Misses 46 46
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that one comment on test class inheritance, LGTM. Thanks!
Once this is merged and released, please let me know the release number so I can pin over at spacetelescope/jdaviz#1949 . Thanks! |
@pllim - the next release is going to be a reasonably big one in terms of features etc so I need to go through and check everything is ok, it might be another week or two until a release. Hope that's ok! If you need this sooner you could always vendor the function temporarily? |
Whoops maybe my suggestion broke the tests. I think a couple of weeks is fine. Thanks! |
Ah yes there was a reason I had it that way - will remove the commit shortly! |
Sorry for the trouble! |
379f153
to
5525494
Compare
@pllim - could you try this out with GWCS instances?
Fix #328