Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Use photutils nightly wheel #224

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

pllim
Copy link
Member

@pllim pllim commented Aug 12, 2024

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.37%. Comparing base (ce0c4b2) to head (8a9f87b).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
- Coverage   83.64%   83.37%   -0.27%     
==========================================
  Files          13       13              
  Lines        1137     1137              
==========================================
- Hits          951      948       -3     
- Misses        186      189       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tepickering tepickering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this! not sure why codecov is complaining about this PR given the only change is in tox.ini. i'd say we ignore that and merge anyway.

@pllim
Copy link
Member Author

pllim commented Sep 17, 2024

Yeah, I don't quite trust codecov project coverage anymore. There was a whole conversation on Astropy to replace it but I don't think there is a replacement that would do everything this codecov is currently doing yet (like the visual inspection stuff). See astropy/astropy#16619

@pllim pllim merged commit 6b8e995 into astropy:main Sep 17, 2024
10 of 11 checks passed
@pllim
Copy link
Member Author

pllim commented Sep 17, 2024

Thanks for review!

@pllim pllim deleted the photutils-nightly branch September 17, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants