Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing Horne extraction #84

Merged
merged 12 commits into from
Mar 29, 2022
Merged

Introducing Horne extraction #84

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
60ed498
Copied first draft of Horne extraction walkthrough
ojustino Jan 31, 2022
69d42c7
Created HorneExtract and OptimalExtract classes
ojustino Feb 24, 2022
ac26e9b
Corrected Horne algorithm, updated arguments
ojustino Feb 26, 2022
7f9ffcc
Added notebook comparing boxcar/Horne on fake data
ojustino Feb 26, 2022
4c1d239
Updated HorneExtract explainer notebook
ojustino Feb 26, 2022
8d30458
Updated HorneExtract/OptimalExtract after reviews
ojustino Mar 9, 2022
ad711cb
Updated instructions in Horne NB requirements file
ojustino Mar 15, 2022
25bccb2
Swapped CCDData requirement to more general NDData
ojustino Mar 18, 2022
9c85fcb
Incorporated CCDData in compare_extractions.ipynb
ojustino Mar 25, 2022
ef07596
Made mask and units optional for array-like images
ojustino Mar 25, 2022
92a37bc
Corrected a notebook import
ojustino Mar 25, 2022
39d3bff
Accepted InverseVariances in HorneExtract
ojustino Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions notebook_sandbox/horne_extract/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@ astropy=5.0
matplotlib==3.5.0
numpy==1.21.4

# remember the following:
# KOSMOS-specific steps for notebook:
# git clone git@github.com:jradavenport/kosmos.git OR git clone https://github.com/jradavenport/kosmos
# fix ".data" error in trace function
# use location as argument to sys.path.insert()

# will also need to clone specreduce
# git clone git@github.com:astropy/specreduce.git OR git clone https://github.com/astropy/specreduce
# find and delete all occurrences of ".data" in kosmos/apextract.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that if NDData or CCDData is used as an input, like me and @eteq have requested, this wouldn't be required. the docstring in kosmos says 2d numpy array, or CCDData object, but the use of the .data attribute means it actually needs something NDData-like.

Copy link
Contributor Author

@ojustino ojustino Mar 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this, but it doesn't work because the KOSMOS trace also tries to call img.shape on the object, which isn't an NDData attribute. The best solution would be to update this notebook to use KosmosTrace once #85 is finished.

# use local location of root KOSMOS repository as argument to sys.path.insert()