Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Use astropy<5.3 for doctest in spectral_cube.rst and analysis.rst #1034

Merged
merged 1 commit into from
Mar 14, 2023
Merged

DOC: Use astropy<5.3 for doctest in spectral_cube.rst and analysis.rst #1034

merged 1 commit into from
Mar 14, 2023

Conversation

pllim
Copy link
Member

@pllim pllim commented Mar 13, 2023 •
edited
Loading

Address doctest failures caused by astropy/astropy#14439 .

Fix to RTD is not covered. I did that in #1032 .

🐱 (1 of 2) xref #1035

@pllim
DOC: Use astropy<5.3 for doctest
167217d 
where they need the order of certain unit str combos, particularly
in spectral_cube.rst and analysis.rst
This was referenced Mar 13, 2023
Merged
Merged
@codecov
Copy link

codecov bot commented Mar 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.09%. Comparing base (6eb7f96) to head (167217d).
Report is 108 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1034   +/-   ##
=======================================
  Coverage   70.09%   70.09%           
=======================================
  Files          64       64           
  Lines        4344     4344           
=======================================
  Hits         3045     3045           
  Misses       1299     1299

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim marked this pull request as ready for review March 13, 2023 22:39
@pllim
Copy link
Member Author

pllim commented Mar 13, 2023

Remaining dev failures are unrelated and already fixed in #1032

@pllim pllim requested a review from rosteen March 13, 2023 22:40
This was referenced Mar 13, 2023
Merged
Merged
rosteen
rosteen approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably update the doctests to work with astropy>=5.3 at some point, but this is ok for now. Thanks!

@rosteen rosteen merged commit 9ceb96b into astropy:main Mar 14, 2023
@rosteen rosteen mentioned this pull request Mar 14, 2023
Closed
@pllim pllim deleted the tst-astropy-5.3-unit-str branch March 14, 2023 14:55
@pllim
Copy link
Member Author

pllim commented Mar 14, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosteen rosteen rosteen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pllim @rosteen