Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add correlation mode to template_correlation #1114

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

zhukgleb
Copy link
Contributor

Added the ability to select a correlation method. The direct method is often slower; on weaker computers, calculating the spectrum offset can take hours. The "direct" flag in the scipy correlation source code refers to direct correlation using numpy. Forward compatibility is enabled by default.

Copy link
Contributor

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, it will be nice to provide this option! I made a couple small suggestions, if you don't have any objections I'll commit those and approve.

specutils/analysis/correlation.py Outdated Show resolved Hide resolved
specutils/analysis/correlation.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (368cfbd) 70.73% compared to head (98428f4) 70.87%.
Report is 11 commits behind head on main.

Files Patch % Lines
specutils/analysis/correlation.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1114      +/-   ##
==========================================
+ Coverage   70.73%   70.87%   +0.14%     
==========================================
  Files          64       64              
  Lines        4483     4498      +15     
==========================================
+ Hits         3171     3188      +17     
+ Misses       1312     1310       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosteen rosteen merged commit fb5bd08 into astropy:main Dec 8, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants