Truncate in template_comparison by default rather than nan_fill #1121
Conversation
… need diff strategy than None fill
…return None instead of blank Spectrum1D
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1121 +/- ##
==========================================
+ Coverage 70.93% 71.07% +0.14%
==========================================
Files 61 61
Lines 4221 4249 +28
==========================================
+ Hits 2994 3020 +26
- Misses 1227 1229 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Tested now. I see it uses only the region of overlap between the template and the observed spectrum to calculate the chi^2, but it also returns the template only in the overlapping region, while it would be useful to get out the full original template properly redshifted and normalized. Here are two screenshots: one shows the observed spectrum and one of the template in its full range; the other shows the observed spectrum and the selected template after template_comparison.
|
@camipacifici Thanks for the comment, I reverted back to returning the full template. I also fixed an existing bug in the redshifting so that it will now work on any unit of spectral axis (e.g., frequency), not just wavelengths. |
Implements the suggestion given in #653. One thing I changed here, which I'm not sure of, is that the returned template is now resampled onto the observed spectrum's spectral axis, in addition to being normalized as previous. Opening as draft since I still need to update the docs, and I'll probably need to add a bit more test coverage.