-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update __str__ and __repr__ for Spectrum1D #1123
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1123 +/- ##
==========================================
- Coverage 71.07% 70.93% -0.14%
==========================================
Files 61 61
Lines 4249 4215 -34
==========================================
- Hits 3020 2990 -30
+ Misses 1229 1225 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the simplification but... have you tested this with numpy 2.0 (from their nightly wheel)?
Looks like your devdeps job pulls in numpy 2.0.dev but I also see warnings, so please inspect the log carefully. https://github.com/astropy/specutils/actions/runs/7832040522/job/21369775774?pr=1123 |
160c09e
to
822f173
Compare
As far as I could tell the only warning was from an upstream package, nothing to do with this. This PR actually fixes some |
I think the actual diff looks reasonable. I think the new str and repr are nicer. Thanks! |
Test failure was a timeout, merging. |
Fixes #1073, as well as improving the readability/concision of the
__repr__
format (especially for things like large cubes). Still tweaking this but it's close, tests will need updating as well.