Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug handling subregions in true_excise #1170

Closed
wants to merge 1 commit into from

Conversation

rosteen
Copy link
Contributor

@rosteen rosteen commented Sep 19, 2024

Looking into #1167 led me to realize that the subregion handling in true_excise was actually using the upper and lower bounds from the full region rather than each subregion. This fixes that. I'll add a test tomorrow that would have caught this, since right now it looks like all tests still pass with the change.

@rosteen rosteen added bug manipulation Spectral manipulation tools labels Sep 19, 2024
@rosteen rosteen added this to the v1.x milestone Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.89%. Comparing base (173d806) to head (8edb04c).
Report is 37 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1170   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files          63       63           
  Lines        4547     4547           
=======================================
  Hits         3951     3951           
  Misses        596      596           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosteen
Copy link
Contributor Author

rosteen commented Sep 24, 2024

I'm actually going to close this without merging, I didn't realize true_excise is not available to call independently from excise_regions, and the current behavior is as documented. Might be worth a deeper revisit sometime but for now I'll leave it as-is.

@rosteen rosteen closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug manipulation Spectral manipulation tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant