Fix mixed unit spectral region extraction #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also gets rid of some more pointless |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
==========================================
+ Coverage 86.87% 86.89% +0.02%
==========================================
Files 63 63
Lines 4556 4564 +8
==========================================
+ Hits 3958 3966 +8
Misses 598 598 ☔ View full report in Codecov by Sentry. |
pllim
reviewed
Oct 15, 2024
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
|
Remote test failures are unrelated, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The left and right index bounds were ending up reversed if the spectrum was in wavelength units and the region was in frequency units, or vice versa, leading to a zero-length extracted spectrum. I confirmed visually in Jdaviz that this now extracts the correct region in those cases, and will add a test shortly. [edit: test that fails on main added]