Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should fix #405 #406

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Should fix #405 #406

merged 1 commit into from
Oct 4, 2021

Conversation

mkuemmel
Copy link
Collaborator

@mkuemmel mkuemmel commented Oct 3, 2021

Not an elegant solution for #405, but it works. I am wondering whether other keywords are also exposed.

@ayllon
Copy link
Member

ayllon commented Oct 4, 2021

I am wondering whether other keywords are also exposed.

Probably yes. I think we need something more flexible and future-proof, so we do not have to tweak keyword per keyword.
If it is urgent, we can merge this as a temporary workaround, though.

@mkuemmel
Copy link
Collaborator Author

mkuemmel commented Oct 4, 2021

Mario, the person from OU NIR, lost some time on this, also since the error is not really transparent.

I understand that the problem is kind of structural since the STL struct that holds the keywords is type safe but the FITS standard is not.

It's kind of a bug that could affect also other users, I would just use this now as a temporary fix.

@marcschefer
Copy link
Member

Well, maybe we can open an issue for a more in-depth fix to be done later so that we don't forget?

@mkuemmel
Copy link
Collaborator Author

mkuemmel commented Oct 4, 2021

I can do that, no problem.

Copy link
Member

@ayllon ayllon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a temporary fix, worth getting it into the codebase before a more generic fix is done

@marcschefer marcschefer merged commit a249f08 into develop Oct 4, 2021
@marcschefer marcschefer deleted the bugfix/int_metedata branch October 4, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants