Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add RequestHandler type #8

Merged
merged 2 commits into from
Jul 18, 2023
Merged

fix: add RequestHandler type #8

merged 2 commits into from
Jul 18, 2023

Conversation

prxg22
Copy link
Contributor

@prxg22 prxg22 commented Jul 8, 2023

  • Install @types/aws-lambda devDependency, which give us access to APIGateway types
  • Add the RequestHandler type
  • Make streamifyResponse() expect as a parameter and returns a RequestHandler

rfoel
rfoel approved these changes Jul 9, 2023
View reviewed changes
Copy link

@rfoel rfoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

astuyve
astuyve approved these changes Jul 18, 2023
View reviewed changes
Copy link
Owner

@astuyve astuyve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@astuyve astuyve merged commit 8c011eb into astuyve:main Jul 18, 2023
@astuyve
Copy link
Owner

astuyve commented Jul 18, 2023

published in v0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfoel rfoel rfoel approved these changes

@astuyve astuyve astuyve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prxg22 @astuyve @rfoel