Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json method for pack serialization/deserialization #914

Closed
wants to merge 0 commits into from

Conversation

mylibrar
Copy link
Collaborator

@mylibrar mylibrar commented Jan 3, 2023

This PR partially fixes #836.

Description of changes

Serialize/deserialize pack into/from json data.

Possible influences of this PR.

Remove dependency on pickle and jsonpickle in pack deserilization/serialization.

Test Conducted

entry_data_structures_test.py
multi_pack_test.py
entry_data_structures_test.py

@mylibrar mylibrar self-assigned this Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #914 (d44a3d0) into master (72e8bce) will increase coverage by 0.06%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master     #914      +/-   ##
==========================================
+ Coverage   80.87%   80.94%   +0.06%     
==========================================
  Files         253      253              
  Lines       19619    19649      +30     
==========================================
+ Hits        15867    15905      +38     
+ Misses       3752     3744       -8     
Impacted Files Coverage Δ
forte/data/data_pack.py 85.26% <ø> (ø)
...atasets/wikipedia/dbpedia/dbpedia_datasets_test.py 100.00% <ø> (ø)
forte/processors/base/writers.py 68.60% <50.00%> (ø)
forte/data/base_pack.py 77.52% <92.59%> (+0.83%) ⬆️
forte/common/constants.py 100.00% <100.00%> (ø)
forte/data/container.py 80.48% <100.00%> (+4.01%) ⬆️
forte/data/multi_pack.py 82.30% <100.00%> (+0.11%) ⬆️
forte/data/ontology/top.py 78.16% <100.00%> (+0.05%) ⬆️
tests/forte/data/entry_data_structures_test.py 90.25% <100.00%> (+4.39%) ⬆️
tests/forte/data/multi_pack_test.py 96.98% <100.00%> (+0.08%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on jsonpickle in pack serialization/deserialization
1 participant