Add an accept header in JSON request to help 3rd party services like …

…localstack (#1721)
async-aws · Jun 5, 2024 · 7236ddb · 7236ddb
1 parent ced8c1b
commit 7236ddb
Show file tree

Hide file tree

Showing 19 changed files with 53 additions and 13 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## NOT RELEASED
 
+### Changed
+
+- Add `Accept: application/json` header in request to fix incompatibility with 3rd party providers
+
 ## 2.1.0
 
 ### Added

diff --git a/src/Input/CreateResolverRequest.php b/src/Input/CreateResolverRequest.php
@@ -278,7 +278,10 @@ public function getTypeName(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/src/Input/DeleteResolverRequest.php b/src/Input/DeleteResolverRequest.php
@@ -86,7 +86,10 @@ public function getTypeName(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/src/Input/GetSchemaCreationStatusRequest.php b/src/Input/GetSchemaCreationStatusRequest.php
@@ -52,7 +52,10 @@ public function getApiId(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/src/Input/ListApiKeysRequest.php b/src/Input/ListApiKeysRequest.php
@@ -83,7 +83,10 @@ public function getNextToken(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/src/Input/ListResolversRequest.php b/src/Input/ListResolversRequest.php
@@ -100,7 +100,10 @@ public function getTypeName(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/src/Input/StartSchemaCreationRequest.php b/src/Input/StartSchemaCreationRequest.php
@@ -69,7 +69,10 @@ public function getDefinition(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/src/Input/UpdateApiKeyRequest.php b/src/Input/UpdateApiKeyRequest.php
@@ -100,7 +100,10 @@ public function getId(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/src/Input/UpdateDataSourceRequest.php b/src/Input/UpdateDataSourceRequest.php
@@ -259,7 +259,10 @@ public function getType(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/src/Input/UpdateResolverRequest.php b/src/Input/UpdateResolverRequest.php
@@ -278,7 +278,10 @@ public function getTypeName(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/tests/Unit/Input/CreateResolverRequestTest.php b/tests/Unit/Input/CreateResolverRequestTest.php
@@ -43,6 +43,7 @@ public function testRequest(): void
         $expected = '
             POST /v1/apis/apiId/types/foo/resolvers HTTP/1.1 200
             Content-type: application/json
+            Accept: application/json
 
             {
                 "cachingConfig": {

diff --git a/tests/Unit/Input/DeleteResolverRequestTest.php b/tests/Unit/Input/DeleteResolverRequestTest.php
@@ -18,7 +18,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/appsync/latest/APIReference/API_DeleteResolver.html
         $expected = '
             DELETE /v1/apis/api123/types/type/resolvers/field HTTP/1.1
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
         ';
 
         self::assertRequestEqualsHttpRequest($expected, $input->request());

diff --git a/tests/Unit/Input/GetSchemaCreationStatusRequestTest.php b/tests/Unit/Input/GetSchemaCreationStatusRequestTest.php
@@ -16,7 +16,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/appsync/latest/APIReference/API_GetSchemaCreationStatus.html
         $expected = '
             GET /v1/apis/api123/schemacreation HTTP/1.1
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
         ';
 
         self::assertRequestEqualsHttpRequest($expected, $input->request());

diff --git a/tests/Unit/Input/ListApiKeysRequestTest.php b/tests/Unit/Input/ListApiKeysRequestTest.php
@@ -18,7 +18,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/appsync/latest/APIReference/API_ListApiKeys.html
         $expected = '
             GET /v1/apis/api123/apikeys?maxResults=1337&nextToken=token HTTP/1.1
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
         ';
 
         self::assertRequestEqualsHttpRequest($expected, $input->request());

diff --git a/tests/Unit/Input/ListResolversRequestTest.php b/tests/Unit/Input/ListResolversRequestTest.php
@@ -19,7 +19,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/appsync/latest/APIReference/API_ListResolvers.html
         $expected = '
             GET /v1/apis/api123/types/type/resolvers?maxResults=1337&nextToken=token HTTP/1.1
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
         ';
 
         self::assertRequestEqualsHttpRequest($expected, $input->request());

diff --git a/tests/Unit/Input/StartSchemaCreationRequestTest.php b/tests/Unit/Input/StartSchemaCreationRequestTest.php
@@ -20,6 +20,7 @@ public function testRequest(): void
         $expected = '
             POST /v1/apis/api123/schemacreation HTTP/1.1
             Content-type: application/json
+            Accept: application/json
 
             {
                "definition": "c2NoZW1hRGVmaW5pdGlvbg=="

diff --git a/tests/Unit/Input/UpdateApiKeyRequestTest.php b/tests/Unit/Input/UpdateApiKeyRequestTest.php
@@ -20,6 +20,7 @@ public function testRequest(): void
         $expected = '
             POST /v1/apis/api123/apikeys/keyId HTTP/1.1
             Content-type: application/json
+            Accept: application/json
 
             {
                "description": "Description here",

diff --git a/tests/Unit/Input/UpdateDataSourceRequestTest.php b/tests/Unit/Input/UpdateDataSourceRequestTest.php
@@ -71,6 +71,7 @@ public function testRequest(): void
         $expected = '
             POST /v1/apis/api123/datasources/dataSourceName HTTP/1.1
             Content-type: application/json
+            Accept: application/json
 
             {
                "description": "This is a description",

diff --git a/tests/Unit/Input/UpdateResolverRequestTest.php b/tests/Unit/Input/UpdateResolverRequestTest.php
@@ -44,6 +44,7 @@ public function testRequest(): void
         $expected = '
             POST /v1/apis/api123/types/type/resolvers/field HTTP/1.1
             Content-type: application/json
+            Accept: application/json
 
             {
                "cachingConfig": {