remove custom log code in favor of macro crate #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
|
Also side note, I'm particularly excited for shorthand kv support as suggested here: current trace!("block_on", {
parent_id: parent_id,
child_id: child_id,
});proposed trace!("block_on", { parent_id, child_id }); |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 16, 2019
199: remove custom log code in favor of macro crate r=stjepang a=yoshuawuyts This removes our custom log macro code in favor of using [`kv-log-macro`](https://github.com/yoshuawuyts/kv-log-macro). This is a temporary crate that exists only until rust-lang/log#353 lands which enables progress on rust-lang/log#328. Thanks! Co-authored-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
Build failed
|
|
can you do cargo fmt and then merge? |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 16, 2019
199: remove custom log code in favor of macro crate r=yoshuawuyts a=yoshuawuyts This removes our custom log macro code in favor of using [`kv-log-macro`](https://github.com/yoshuawuyts/kv-log-macro). This is a temporary crate that exists only until rust-lang/log#353 lands which enables progress on rust-lang/log#328. Thanks! Co-authored-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes our custom log macro code in favor of using
kv-log-macro. This is a temporary crate that exists only until rust-lang/log#353 lands which enables progress on rust-lang/log#328. Thanks!