Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TcpStream: Shutdown write direction in poll_close. #618

Merged
merged 1 commit into from
Dec 13, 2019
Merged

TcpStream: Shutdown write direction in poll_close. #618

merged 1 commit into from
Dec 13, 2019

Conversation

twittner
Copy link
Contributor

Fixes #599.

yoshuawuyts
yoshuawuyts approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@yoshuawuyts yoshuawuyts merged commit 96d6fc4 into async-rs:master Dec 13, 2019
@twittner twittner deleted the poll_close_shutdown branch December 13, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<TcpStream as Write>::poll_close does nothing
2 participants
@twittner @yoshuawuyts