Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed flat_map and flatten #701

Merged
merged 11 commits into from
Jun 18, 2020
Merged

Fixed flat_map and flatten #701

merged 11 commits into from
Jun 18, 2020

Conversation

olegnn
Copy link
Contributor

@olegnn olegnn commented Feb 7, 2020 •
edited
Loading

Current implementations of flat_map and flatten have a bug. If stream returns Poll::Pending while inner_stream is already completed, inner_stream will be polled again after completion as many times as stream returns Poll::Pending.

@olegnn olegnn changed the title Fixed flat_map Fixed flat_map and flatten Feb 8, 2020
k-nasa
k-nasa reviewed Mar 21, 2020
View reviewed changes
tests/stream.rs Outdated Show resolved Hide resolved
src/stream/stream/flatten.rs Outdated Show resolved Hide resolved
src/stream/stream/flatten.rs Outdated Show resolved Hide resolved
src/stream/stream/flat_map.rs Outdated Show resolved Hide resolved
src/stream/stream/flat_map.rs Outdated Show resolved Hide resolved
@k-nasa
Copy link
Member

k-nasa commented Mar 21, 2020

@olegnn Thanks for PR and sorry for the late review.

@dignifiedquire dignifiedquire merged commit 5d55fa7 into async-rs:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-nasa k-nasa k-nasa left review comments

@dignifiedquire dignifiedquire dignifiedquire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olegnn @k-nasa @dignifiedquire