Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong slice index when reading a file #802

Merged
merged 1 commit into from
May 29, 2020
Merged

Fix wrong slice index when reading a file #802

merged 1 commit into from
May 29, 2020

Conversation

jerry73204
Copy link
Contributor

As the title, it fixes the wrong slice index of an internal buffer when reading a File.

dignifiedquire
dignifiedquire approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@dignifiedquire dignifiedquire merged commit 0ec027d into async-rs:master May 29, 2020
@jerry73204
Copy link
Contributor Author

I found this issue affects many of my applications. If possible, release 1.6.1 along with this and other critical fix-ups?

@dignifiedquire
Copy link
Member

yes, I'll try and cut a release tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dignifiedquire dignifiedquire dignifiedquire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerry73204 @dignifiedquire