Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(net): ensure the reactor and runtime are running #819

Merged
merged 3 commits into from
Jun 18, 2020
Merged

fix(net): ensure the reactor and runtime are running #819

merged 3 commits into from
Jun 18, 2020

Conversation

dignifiedquire
Copy link
Member

If this is not done, then reactor is not running, resulting in the sockets not actually connecting.

Closes #818

@dignifiedquire
fix(net): ensure the reactor and runtime are running
093d640 
If this is not done, then reactor is not running, resulting in the sockets not actually connecting.

Closes #818
yoshuawuyts
yoshuawuyts approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- though we should probably apply this to our timers as well

@dignifiedquire dignifiedquire merged commit 5f418f0 into master Jun 18, 2020
@dignifiedquire dignifiedquire deleted the fix-sockets branch June 18, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[partial regression] Do not require a runtime in order to use net sockets
2 participants
@dignifiedquire @yoshuawuyts