Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Future impl for JoinHandle on wasm #870

Closed
wants to merge 1 commit into from
Closed

Fix the Future impl for JoinHandle on wasm #870

wants to merge 1 commit into from

Conversation

expenses
Copy link

On wasm, a JoinFuture uses a futures_channel::oneshot::Receiver internally, but as this returns Result<T, Canceled>, the code doesn't compile on wasm.

@expenses expenses mentioned this pull request Aug 31, 2020
Closed
@jbr
Copy link
Contributor

jbr commented Aug 31, 2020

I believe this is solving the same problem as #863

@expenses
Copy link
Author

expenses commented Sep 1, 2020

Closing due to #863.

@expenses expenses closed this Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@expenses @jbr