Skip to content

Commit

Permalink
code review comments addressed
Browse files Browse the repository at this point in the history
  • Loading branch information
m00g3n committed Aug 28, 2019
1 parent 8e42ac4 commit 689f1e9
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions library/src/helpers/parser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,22 +26,21 @@ type ParseDocumentFromURL = (
) => Promise<AsyncAPI>;

export default class Parser {
private parseDocument: ParseDocument;
private parseDocumentFromURL: ParseDocumentFromURL;
private parseSchema: ParseDocument;
private parseSchemaFromURL: ParseDocumentFromURL;

constructor(parse: ParseDocument, parseURL: ParseDocumentFromURL) {
this.parseDocument = parse;
this.parseDocumentFromURL = parseURL;
this.parseSchema = parse;
this.parseSchemaFromURL = parseURL;
}

async parse(
content: string | any,
parserOptions?: ParserOptions,
): Promise<ParserReturn> {
try {
const data: AsyncAPI = await this.parseDocument(content, parserOptions);
const data: AsyncAPI = await this.parseSchema(content, parserOptions);
return { data };

} catch (err) {
return this.handleError(err);
}
Expand All @@ -52,7 +51,7 @@ export default class Parser {
parserOptions?: ParserOptions,
): Promise<ParserReturn> {
try {
const data: AsyncAPI = await this.parseDocumentFromURL(
const data: AsyncAPI = await this.parseSchemaFromURL(
arg.url,
arg.requestOptions,
parserOptions,
Expand Down

0 comments on commit 689f1e9

Please sign in to comment.