Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type checking if schema property is not string #68

Merged
merged 3 commits into from
Sep 17, 2019
Merged

type checking if schema property is not string #68

merged 3 commits into from
Sep 17, 2019

Conversation

rmelian
Copy link
Contributor

@rmelian rmelian commented Sep 13, 2019 •
edited
Loading

Description

Changes proposed in this pull request:

  • check if properties are objects and valid
  • check for schema type === 'object'

Related issue(s)

#67 #69

magicmatatjahu
magicmatatjahu approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this must be done in beautifier.ts.

@rmelian
Copy link
Contributor Author

rmelian commented Sep 16, 2019

I'll update this PR, thanks

@rmelian
Copy link
Contributor Author

rmelian commented Sep 16, 2019

PR updated

@magicmatatjahu magicmatatjahu merged commit b73d44c into asyncapi:master Sep 17, 2019
This was referenced Sep 25, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

@aerfio aerfio Awaiting requested review from aerfio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmelian @magicmatatjahu