Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix missing toc #230

Merged
merged 1 commit into from
Feb 18, 2022
Merged

docs: fix missing toc #230

merged 1 commit into from
Feb 18, 2022

Conversation

Souvikns
Copy link
Member

Description

For some reason, the TOC is not generated in README.md. Just manually creating it in this PR.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@magicmatatjahu
Copy link
Member

@Souvikns Did you run manually generate:markdown:toc? I think that we have some problem on the workflow side and we should try to make it by merging PR.

@Souvikns
Copy link
Member Author

Souvikns commented Feb 14, 2022

@Souvikns Did you run manually generate:markdown:toc? I think that we have some problem on the workflow side and we should try to make it by merging PR.

Yeah, I just ran the command and pushed I figured something was wrong with the workflow because we have a command for this, but was not able to find it out.

@magicmatatjahu
Copy link
Member

@Souvikns Yeah we have that here https://github.com/asyncapi/cli/blob/master/.github/workflows/if-nodejs-version-bump.yml#L31 I also wonder why it didn't run on the post release workflow 🤔 I can accept that changes because I don't think so that we should wait for that, but please rerun again the markdown-toc generation because maybe there are some changes in the master and ping me, ok? :)

@Souvikns
Copy link
Member Author

@magicmatatjahu I just rerun and there aren't any new changes and the branch is up to date with upstream/master

@Souvikns
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 663b260 into asyncapi:master Feb 18, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Souvikns added a commit to Souvikns/cli that referenced this pull request Mar 8, 2022
* docs: fix missing toc (asyncapi#230)

* feat: add global specification watcher (asyncapi#220)

Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>

* chore(release): v0.14.0 (asyncapi#237)

* docs: add imabp as a contributor for code (asyncapi#239)

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* fix: update @asyncapi/studio to 0.10.0 version (asyncapi#241)

* chore(release): v0.14.1 (asyncapi#242)

* feat: added testing for new (asyncapi#212)

* docs: add Samridhi-98 as a contributor for test (asyncapi#248)

* ci: update global workflows (asyncapi#246)

* chore(release): v0.15.0 (asyncapi#249)

* feat: migrate to latest oclif version (asyncapi#203)

* chore: update bot name from codeowners file (asyncapi#247)

* ci: update global workflows (asyncapi#250)

* Create test.yml

* Update test.yml

* Update test.yml

* Update test.yml

* Update test.yml

Co-authored-by: Abir <abir.pal899@gmail.com>
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
Co-authored-by: asyncapi-bot <61865014+asyncapi-bot@users.noreply.github.com>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Samriddhi <Agrawalsamriddhi83@gmail.com>
Co-authored-by: asyncapi-bot <bot+chan@asyncapi.io>
Souvikns added a commit to Souvikns/cli that referenced this pull request Mar 8, 2022
* docs: fix missing toc (asyncapi#230)

* feat: add global specification watcher (asyncapi#220)

Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>

* chore(release): v0.14.0 (asyncapi#237)

* docs: add imabp as a contributor for code (asyncapi#239)

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* fix: update @asyncapi/studio to 0.10.0 version (asyncapi#241)

* chore(release): v0.14.1 (asyncapi#242)

* feat: added testing for new (asyncapi#212)

* docs: add Samridhi-98 as a contributor for test (asyncapi#248)

* ci: update global workflows (asyncapi#246)

* chore(release): v0.15.0 (asyncapi#249)

* feat: migrate to latest oclif version (asyncapi#203)

* chore: update bot name from codeowners file (asyncapi#247)

* ci: update global workflows (asyncapi#250)

* Create test.yml

* Update test.yml

* Update test.yml

* Update test.yml

* Update test.yml

* Update test.yml

Co-authored-by: Abir <abir.pal899@gmail.com>
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
Co-authored-by: asyncapi-bot <61865014+asyncapi-bot@users.noreply.github.com>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Samriddhi <Agrawalsamriddhi83@gmail.com>
Co-authored-by: asyncapi-bot <bot+chan@asyncapi.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants