AsyncAPI logo in repositories are not viable with GitHub darkmode

[jonaslagoni]

All our repositories use the same logo and it does not look great with the new darkmode GitHub recently introduced. Just wanted to raise awareness in case its something we want to address.

[fmvilas]

Reported here: https://github.com/githubevents/universe2020/discussions/372.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

[derberg]

@jonaslagoni @fmvilas seems like a good solution without waiting for GitHub to support it natively

tailwindlabs/tailwindcss#5233

[fmvilas]

I was going to suggest this. Perfect. Let's make it a sticker 😄

[derberg]

I think they communicated recently that this is now natively supported by GitHub, right?
but I guess we will solve it once @mcturco completes work on refreshed brand? Can we leave it on you Missy?

[mcturco]

@jonaslagoni @fmvilas @derberg
When I was reading the github markdown docs the other day I saw that there is a way to switch the image based on the current theme. Here is the link to read it in the docs.

I haven't tested it out yet, but curious as to if it will solve the problem. 🤔 I would suggest the color AsyncAPI logo with black text on Light mode, and the colored AsyncAPI logo with white text on Dark mode.

If that doesn't work, I would be happy to create a banner similar to the one I have in the README for the brand repo 😄

[mcturco]

Unfortunately, it seems like the dark mode/light mode options that GH has introduced are a little buggy. When I was testing this method and the prefers-color-scheme method, it seems like it only does the switch based on the user's OS settings and ignores the theme settings in GH, which is strange.

To resolve this, I just used the same banner design that I created for the brand repo, that way the logo is visible on any theme. See the linked PR! #209

[magicmatatjahu]

@mcturco Could we create issue for that:

Unfortunately, it seems like the dark mode/light mode options that GH has introduced are a little buggy. When I was testing this method and the prefers-color-scheme method, it seems like it only does the switch based on the user's OS settings and ignores the theme settings in GH, which is strange.

? 🤔 I think that people from GH should know that problem - or probably some person already created it 😄

[derberg]

When I was recently working on my new blog, I had hacked my logo to support both, dark and light mode by adding custom style to SVG, and fill set to currentColor and it kinda works

check out https://raw.githubusercontent.com/derberg/derberg.github.io/main/data/logo.svg

[mcturco]

@magicmatatjahu @derberg There's actually a long support thread on GH where a lot of people are having issues with changing logo versions on different themes. I think it's because there are too many conflicts between the OS's current theme and GH's own themes. I suppose they are working on it?

Here's a link to the most recent update (13 days ago) from a staff member at GH on the issue: https://git.luolix.topmunity/t/support-theme-context-for-images-in-light-vs-dark-mode/147981/88

Looks like they are still working on it!

[mcturco]

@derberg I know I just submitted a PR that fixed the logo on dark mode for the community repo, but we should keep this issue open for fixes to the other repos, correct?

[derberg]

Makes sense 👍🏼

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

[mcturco]

I actually think this issue is resolved since we changed the logo on all the repos with the new brand. @derberg @jonaslagoni should we close this issue?