Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: toggle logos in README on light and dark mode #209

Merged
merged 3 commits into from
Feb 2, 2022

Conversation

mcturco
Copy link
Member

@mcturco mcturco commented Dec 22, 2021

This hopefully fixes the issue where the logo doesn't show up in dark mode on README file

Resolves #4

@mcturco
Copy link
Member Author

mcturco commented Dec 22, 2021

If this PR is approved and merged, I can make this change across all repos for consistency! 😄

@mcturco
Copy link
Member Author

mcturco commented Jan 31, 2022

@derberg when you get a sec, could you have a look at this? Just realized it has been sitting here for a while 😅

@derberg
Copy link
Member

derberg commented Feb 2, 2022

@mcturco oh, I don't feel comfortable accepting anything related to logos 😆
@fmvilas 🙏🏼

@derberg derberg requested a review from fmvilas February 2, 2022 14:27
@mcturco
Copy link
Member Author

mcturco commented Feb 2, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 6484b59 into asyncapi:master Feb 2, 2022
@mcturco mcturco deleted the readme-logo-edits branch February 2, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsyncAPI logo in repositories are not viable with GitHub darkmode
4 participants