feat: add http adapter support for glee #320

ritik307 · 2022-06-26T10:40:17Z

Description

Implement the HTTP adapter for both server and client

Aims to -

connect HTTP server as per the specification.
Handle incoming messages only on the channels specified in the specification
Send appropriate responses from the registered function.
connect the HTTP client as per the specification.
HTTP client should be able to connect via any other protocol and provide response in the specified registered function.

Steps to test the codeflow

Steps to run the base code

npm i
npm run dev

Steps to run the server
4. cd examples/anime-http/server
5. npm i
6. npm run dev

Steps to run the client
8. cd examples/anime-http/client
9. npm i
10. npm run dev

github-actions

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

fmvilas

Left a few comments.

Along with those, I'm adding two more generic comments here:

What does "adding HTTP header init" means? 😄
It would be great if you can consider making it clear when it should be creating an HTTP server and when it should be creating a client (client can be done in another PR). For instance, if the server is marked as "local", then it should create a server. Otherwise, it shouldn't. See an example here: https://github.com/asyncapi/glee/pull/319/files#diff-5a59976f2bbdbefa8fb1b10842622e9c61def3c47869b93b2d0d3d1374530734R21.

examples/simple/asyncapi.yaml

examples/simple/.glee/functions/onTest.js

examples/simple/asyncapi.yaml

src/adapters/http/index.ts

sonarqubecloud · 2022-07-10T16:10:28Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.0% Duplication

ritik307 · 2022-07-10T16:11:47Z

Left a few comments.

Along with those, I'm adding two more generic comments here:

What does "adding HTTP header init" means? smile

It would be great if you can consider making it clear when it should be creating an HTTP server and when it should be creating a client (client can be done in another PR). For instance, if the server is marked as "local", then it should create a server. Otherwise, it shouldn't. See an example here: https://github.com/asyncapi/glee/pull/319/files#diff-5a59976f2bbdbefa8fb1b10842622e9c61def3c47869b93b2d0d3d1374530734R21.

Sorry for that I will try to be more clear on the commit messages 🙂

ritik307 · 2022-07-10T16:13:26Z

@fmvilas Can you kindly provide me with some resources to study web sockets, I am baffled with web sockets at the moment.😟

fmvilas · 2022-07-11T07:56:30Z

Sure, MDN has a great resource: https://developer.mozilla.org/en-US/docs/Web/API/WebSockets_API.

…s as an array for holding multiple res

examples/simple/asyncapi.yaml

src/adapters/http/index.ts

Souvikns

Since you are adding a new adapter to support the HTTP server you have to update the docs accordingly.

.gitignore

examples/simple/.glee/functions/onTest.js

examples/simple/asyncapi.yaml

ritik307 · 2022-11-27T16:49:27Z

@Souvikns I have changed the examples/simple/asyncapi.yaml file according to the docs that you have referred but i am not sure whether i used $ref: '#/components/messages/testReply' at correct place or not. Kindly check it and let me know if any further changes are required

examples/simple/asyncapi.yaml

sonarqubecloud · 2022-12-05T16:15:38Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.0% Duplication

KhudaDad414

LGTM!

fmvilas

Left some comments

src/lib/message.ts

ritik307 · 2023-03-09T17:49:03Z

@fmvilas Made the changes you have suggested. Please check

fmvilas

Left some more comments. Please don't rush it out. Take your time to evaluate what's the best solution. For instance, I see you're repeating { [key: string]: string } | { [key: string]: string[] } in multiple places. Maybe it's time to define it as a custom type to reuse it.

src/lib/message.ts

fmvilas

Left a few more suggestions

src/adapters/http/client.ts

src/adapters/http/server.ts

src/lib/functions.ts

src/lib/index.d.ts

src/lib/message.ts

sonarqubecloud · 2023-03-11T10:04:38Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

fmvilas

LGTM 👍

Souvikns · 2023-03-22T06:37:59Z

/rtm

asyncapi-bot · 2023-03-22T06:43:54Z

🎉 This PR is included in version 0.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Co-authored-by: Ritik Rawal <ritikrawal@MacBook-Pro-5.local>%0ACo-authored-by: Ritik Rawal <ritikrawal@MacBook-Pro-85.local>%0ACo-authored-by: Ritik Rawal <ritikrawal@ip-192-168-0-101.ap-south-1.compute.internal>%0ACo-authored-by: Ritik Rawal <ritikrawal@ip-192-168-0-102.ap-south-1.compute.internal>

adding http header init

417fbd2

ritik307 requested review from fmvilas, jonaslagoni and asyncapi-bot-eve as code owners June 26, 2022 10:40

github-actions bot reviewed Jun 26, 2022

View reviewed changes

ritik307 changed the title ~~adding http header init~~ feat: adding http header init Jun 26, 2022

fmvilas requested changes Jul 5, 2022

View reviewed changes

resolved some requested changes

a1d2778

chore: updated the asyncapi.yml with title and desc. and made this.re…

52001a5

…s as an array for holding multiple res

Souvikns reviewed Nov 7, 2022

View reviewed changes

examples/simple/asyncapi.yaml Outdated Show resolved Hide resolved

Souvikns reviewed Nov 7, 2022

View reviewed changes

src/adapters/http/index.ts Outdated Show resolved Hide resolved

Souvikns requested changes Nov 7, 2022

View reviewed changes

fmvilas requested changes Nov 8, 2022

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

examples/simple/.glee/functions/onTest.js Outdated Show resolved Hide resolved

examples/simple/asyncapi.yaml Outdated Show resolved Hide resolved

Ritik Rawal added 2 commits November 27, 2022 19:23

added .glee folder to gitignore and also updated .glee folder path

978b87b

updated asyncapi.yaml

2bd2a42

ritik307 requested a review from Souvikns November 27, 2022 16:50

Souvikns reviewed Nov 28, 2022

View reviewed changes

examples/simple/asyncapi.yaml Outdated Show resolved Hide resolved

Souvikns reviewed Nov 28, 2022

View reviewed changes

examples/simple/asyncapi.yaml Outdated Show resolved Hide resolved

Ritik Rawal added 2 commits December 5, 2022 21:44

added example example for http protocol

b9b998c

added example for http protocol

f4e3008

Ritik Rawal added 4 commits January 26, 2023 15:08

removed package-log from example

dff4daa

resolved merge conflicts

6e56ab0

added client for http server

32a611e

added client and server example and adaptor for http

4f50fcc

ritik307 requested review from Souvikns and KhudaDad414 and removed request for Souvikns March 7, 2023 09:35

Ritik Rawal added 2 commits March 8, 2023 16:29

made requested changes

223ea80

resolved code smell

4bfc92f

ritik307 requested review from fmvilas and removed request for KhudaDad414 March 8, 2023 11:06

KhudaDad414 previously approved these changes Mar 9, 2023

View reviewed changes

fmvilas requested changes Mar 9, 2023

View reviewed changes

src/lib/message.ts Outdated Show resolved Hide resolved

src/lib/message.ts Outdated Show resolved Hide resolved

made requested changes regaridng updating query data type

5cc0755

ritik307 dismissed KhudaDad414’s stale review via 5cc0755 March 9, 2023 17:48

ritik307 requested a review from fmvilas March 9, 2023 17:49

fmvilas requested changes Mar 9, 2023

View reviewed changes

src/lib/message.ts Outdated Show resolved Hide resolved

src/lib/message.ts Outdated Show resolved Hide resolved

made changes regarding query param type in message

a4ff2a5

ritik307 requested a review from fmvilas March 10, 2023 04:29

fmvilas requested changes Mar 11, 2023

View reviewed changes

added types to missing query definations

ae82f26

ritik307 requested a review from fmvilas March 11, 2023 10:06

fmvilas approved these changes Mar 20, 2023

View reviewed changes

fmvilas removed the do-not-merge label Mar 20, 2023

Souvikns approved these changes Mar 22, 2023

View reviewed changes

asyncapi-bot added the ready-to-merge label Mar 22, 2023

asyncapi-bot merged commit 2557652 into asyncapi:master Mar 22, 2023

asyncapi-bot added the released label Mar 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add http adapter support for glee #320

feat: add http adapter support for glee #320

ritik307 commented Jun 26, 2022 •

edited

Loading

github-actions bot left a comment

fmvilas left a comment

sonarqubecloud bot commented Jul 10, 2022

ritik307 commented Jul 10, 2022

ritik307 commented Jul 10, 2022

fmvilas commented Jul 11, 2022

Souvikns left a comment

ritik307 commented Nov 27, 2022

sonarqubecloud bot commented Dec 5, 2022

KhudaDad414 left a comment

fmvilas left a comment

ritik307 commented Mar 9, 2023

fmvilas left a comment

fmvilas left a comment

sonarqubecloud bot commented Mar 11, 2023

fmvilas left a comment

Souvikns commented Mar 22, 2023

asyncapi-bot commented Mar 22, 2023

feat: add http adapter support for glee #320

feat: add http adapter support for glee #320

Conversation

ritik307 commented Jun 26, 2022 • edited Loading

Description

Aims to -

Steps to test the codeflow

github-actions bot left a comment

Choose a reason for hiding this comment

fmvilas left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jul 10, 2022

ritik307 commented Jul 10, 2022

ritik307 commented Jul 10, 2022

fmvilas commented Jul 11, 2022

Souvikns left a comment

Choose a reason for hiding this comment

ritik307 commented Nov 27, 2022

sonarqubecloud bot commented Dec 5, 2022

KhudaDad414 left a comment

Choose a reason for hiding this comment

fmvilas left a comment

Choose a reason for hiding this comment

ritik307 commented Mar 9, 2023

fmvilas left a comment

Choose a reason for hiding this comment

fmvilas left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Mar 11, 2023

fmvilas left a comment

Choose a reason for hiding this comment

Souvikns commented Mar 22, 2023

asyncapi-bot commented Mar 22, 2023

ritik307 commented Jun 26, 2022 •

edited

Loading