Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable any testing on draft PR #204

Merged
merged 3 commits into from
Nov 25, 2020

Conversation

jonaslagoni
Copy link
Member

Description
Ensured that tests and analysis are only run when PR is not in draft mode.

Related issue(s)
Fixes #200

@jonaslagoni jonaslagoni marked this pull request as ready for review November 23, 2020 14:55
@jonaslagoni jonaslagoni marked this pull request as draft November 23, 2020 14:57
@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonaslagoni jonaslagoni marked this pull request as ready for review November 23, 2020 15:02
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonaslagoni
Copy link
Member Author

@jonaslagoni Took it from? https://git.luolix.topmunity/t/dont-run-actions-on-draft-pull-requests/16817/16

Yep that was the main source for the solution 😄

@derberg derberg merged commit 6fc90ea into asyncapi:master Nov 25, 2020
@derberg derberg changed the title chore: Disabled any testing on draft PR ci: disable any testing on draft PR Nov 25, 2020
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jonastg added a commit to jonastg/parser-js that referenced this pull request Jan 18, 2021
* master: (24 commits)
  chore: Refactored code location for iterators (asyncapi#225)
  chore(release): 1.3.1 (asyncapi#222)
  fix: apply traits to standalone messages from components section (asyncapi#214)
  test: improve feedback loop from browser tests (asyncapi#216)
  ci: fix the space-issue in bump workflow (asyncapi#218)
  ci: update global workflows (asyncapi#217)
  chore(deps): bump ini from 1.3.5 to 1.3.7 (asyncapi#215)
  ci: rename pr testing job name and test node 14 (asyncapi#213)
  ci: bump workflow to start on push instead of release (asyncapi#212)
  chore(release): 1.3.0 (asyncapi#211)
  feat: add a traverse schema function (asyncapi#198)
  ci: add workflow that bumps parser in other asyncapi repos (asyncapi#208)
  ci: fix release workflow step that is responsible for handling twitter (asyncapi#209)
  ci: update global workflows (asyncapi#206)
  ci: disable any testing on draft PR (asyncapi#204)
  chore(release): 1.2.0 (asyncapi#202)
  feat: extend the components and asyncapi model with has-like functions (asyncapi#192)
  chore(deps-dev): bump semantic-release from 17.0.6 to 17.2.3 (asyncapi#199)
  chore(release): 1.1.1 (asyncapi#197)
  fix: channels with name '/' fail on validation (asyncapi#196)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable PR testing if its a draft
4 participants