Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: port channel, channel-parameter and schema models #547

Merged
merged 2 commits into from
May 9, 2022

Conversation

magicmatatjahu
Copy link
Member

Description

Port Channel, Channel-parameter and Schema models.

Related issue(s)
Part of #481
Part of #482

@sonarcloud
Copy link

sonarcloud bot commented May 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

However, not sure if you want to wait for asyncapi/parser-api#64 (comment) to conclude so you can add the missing methods here or rather merge this and create a PR later.

@magicmatatjahu
Copy link
Member Author

@smoya Don't worry, if Fran/Jonas reply to our thoughts I will update my PR and add also the missing methods from this PR :) Thanks for review!

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 11b54c7 into asyncapi:next-major May 9, 2022
@magicmatatjahu magicmatatjahu deleted the next/port-channel branch May 9, 2022 15:28
magicmatatjahu added a commit to magicmatatjahu/parser-js that referenced this pull request Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants