refactor: port components model #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmatatjahu
requested review from
fmvilas,
jonaslagoni,
derberg and
asyncapi-bot-eve
as code owners
magicmatatjahu
commented
May 10, 2022
src/models/components.ts
Outdated
Comment on lines
29
to
30
| externalDocs(): Record<string, ExternalDocumentationInterface>; | ||
| tags(): Record<string, TagInterface>; |
There was a problem hiding this comment.
More info asyncapi/spec#792
There was a problem hiding this comment.
Why are you adding components that have yet to be accepted into the spec? 🤔
There was a problem hiding this comment.
Why not? Operations in 3.0.0 will land in components anyway.
There was a problem hiding this comment.
Cause if the changes are rejected, they should not already be part of the parser 🙂 You still follow RFC.
|
Kudos, SonarCloud Quality Gate passed!
|
jonaslagoni
approved these changes
May 16, 2022
|
@jonaslagoni Thanks! |
|
/rtm |
magicmatatjahu
added a commit
to magicmatatjahu/parser-js
that referenced
this pull request
Oct 3, 2022
derberg
pushed a commit
that referenced
this pull request
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ComponentsmodelRelated issue(s)
Part of #481
Part of #482
cc @smoya