Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: exports extras and missed things #635

Merged
merged 2 commits into from
Oct 4, 2022
Merged

refactor: exports extras and missed things #635

merged 2 commits into from
Oct 4, 2022

Conversation

magicmatatjahu
Copy link
Member

Description

  • Export several functions needed by Studio's integration and Generator's integration.
  • Export extras in parse() output - we need document Spectral's instance to get location/range of given JSON Path.
  • Fix import in from file.

Related issue(s)
Part of #481

@magicmatatjahu magicmatatjahu added the enhancement New feature or request label Sep 30, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

smoya
smoya approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔

jonaslagoni
jonaslagoni approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 73bd4fb into asyncapi:next-major Oct 4, 2022
@magicmatatjahu magicmatatjahu deleted the next/export-extras branch October 4, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoya smoya smoya approved these changes

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@magicmatatjahu @smoya @jonaslagoni @asyncapi-bot