-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add isOldAsyncAPIDocument helper #687
feat: add isOldAsyncAPIDocument helper #687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to add a converter as well? I.e. from old parser document to new version? The code you send works:
// Is from old parser
const parsedJSON = input.json();
const detailed = createDetailedAsyncAPI(parsedJSON, parsedJSON);
doc = createAsyncAPIDocument(detailed);
one cent from me, please update readme where we document all custom parser extensions |
@jonaslagoni I can add but it won't work in 100% cases. |
Kudos, SonarCloud Quality Gate passed! |
@jonaslagoni Done Could you check again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, but other then that it LGTM 👍
/rtm |
🎉 This PR is included in version 2.0.0-next-major.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
x-parser-api-version
to have info about parser-api used in AsyncAPI modelisOldAsyncAPIDocument
helper function to check if document use old apiisAsyncAPIDocument
cc @jonaslagoni as you want :)