Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure header must be an object schema #10

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

derberg
Copy link
Member

@derberg derberg commented Jun 16, 2020

Description

now validation fails with:

"headers": {
    "type": "integer",
    "enum": [1, 2]
}

but it is allowing:

"headers": {
    "type": "object",
    "properties": {
      "my-app-header": {
        "type": "integer",
        "minimum": 0,
        "maximum": 100
      }
    }
  }

Related issue(s)
Fixes asyncapi/parser-js#68

@derberg derberg requested a review from fmvilas June 16, 2020 16:33
@derberg derberg merged commit 1cae0cd into asyncapi:master Jun 17, 2020
@derberg derberg deleted the headers branch June 17, 2020 07:13
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header other than object doesn't cause validation fail
3 participants