chore: add CODEOWNERS #138
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Sounds good. My only suggestion is to add @jonaslagoni because of this: #128. I know it's not yet merged but that solves a lot of bugs and improves the repo by a lot.
|
|
||
| # The default owners are automatically added as reviewers when you open a pull request unless different owners are specified in the file. | ||
|
|
||
| * @fmvilas @derberg @github-actions[bot] |
There was a problem hiding this comment.
| * @fmvilas @derberg @github-actions[bot] | |
| * @fmvilas @derberg @jonaslagoni @github-actions[bot] |
There was a problem hiding this comment.
but then we are not aligned with spec repo 😉
There was a problem hiding this comment.
Yeah, I'm happy to wait but I'd not worry about aligning with spec. JSON Schemas are not the spec but a partial representation of it. If we align here we'd have to align on parsers too, which I don't think makes sense. What do you think?
There was a problem hiding this comment.
so I know that we treat JSON Schema as a tool, but I was thinking about the alignment because it almost in 90% reflects the spec, not like in case of parser, and parser anyway depends on JSON Schema again in 90% for the validation.
if spec owners are not only gatekeepers for JSON Schema, in theory, it may happen that some validation rule can be changed here but not in spec. You know what I mean?
🤔
There was a problem hiding this comment.
if spec owners are not only gatekeepers for JSON Schema, in theory, it may happen that some validation rule can be changed here but not in spec. You know what I mean?
Yeah, I get it, I just don't think it's very different than a parser implementing a custom validation that is not defined in the spec (like in asyncapi/spec#650). Anyway, I'm not going to block this PR just because of that.
I'm approving and we can consider adding other people later 👍
|
🎉 This PR is included in version 2.13.0-2022-01-release.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@fmvilas I wasn't sure here so I took an approach that JSON Schema is very closely aligned with
specthen it should have exactly the same owners asspecrepo.We can rethink once we make a final decision about #130
Thoughts?