Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add googlepubsub bindings #253

Merged
merged 1 commit into from
Sep 27, 2022
Merged

feat: add googlepubsub bindings #253

merged 1 commit into from
Sep 27, 2022

Conversation

whitlockjc
Copy link
Collaborator

@whitlockjc whitlockjc commented Sep 19, 2022 •
edited
Loading

Add the Google Cloud Pub/Sub bindings (googlepubsub) to the bindings list.

Related issue(s)
Bindings PR: asyncapi/bindings#141
Spec PR: asyncapi/spec#836

github-actions[bot]
github-actions bot reviewed Sep 19, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

This was referenced Sep 19, 2022
Merged
Merged
@char0n char0n mentioned this pull request Sep 20, 2022
Closed
61 tasks
@char0n
Copy link
Collaborator

char0n commented Sep 20, 2022

Added as pending candidate for 2.5 release - asyncapi/spec#830

@derberg
Copy link
Member

derberg commented Sep 26, 2022

@dalelane hey, we are missing your approval for merge

dalelane
dalelane approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@dalelane dalelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry - missed this!

@char0n
Copy link
Collaborator

char0n commented Sep 27, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 5ab1eab into asyncapi:next-spec Sep 27, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.15.0-next-spec.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.2.0-next-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@derberg derberg mentioned this pull request Jan 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@derberg derberg derberg approved these changes

@dalelane dalelane dalelane approved these changes

@fmvilas fmvilas fmvilas approved these changes

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@whitlockjc @char0n @derberg @asyncapi-bot @fmvilas @dalelane