Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for non-JSON schemas (i.e. Protobuf, XSD, etc.) #241

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

fmvilas
Copy link
Member

@fmvilas fmvilas commented Jul 24, 2019

Fixes #216

Props to @jstoiko.

Copy link
Contributor

@WaleedAshraf WaleedAshraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmvilas
Copy link
Member Author

fmvilas commented Jul 24, 2019

I'm moving forward and gonna merge this PR. Please, if you see something wrong, missing, or just don't agree with the changes, don't hesitate to leave a comment after it's merged. I'll be happy to address these questions afterward.

@fmvilas fmvilas merged commit 8a3e874 into master Jul 24, 2019
@fmvilas fmvilas deleted the feature/remove-support-for-non-json-schemas branch July 24, 2019 10:38
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.0.0 REVIEW] Clarify usage of JSON References (/Pointers) for non-JSON data structures
3 participants