Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing security schemes to correlation id example #515

Merged
merged 3 commits into from
Mar 17, 2021
Merged

fix: add missing security schemes to correlation id example #515

merged 3 commits into from
Mar 17, 2021

Conversation

195858
Copy link
Contributor

@195858 195858 commented Mar 16, 2021

Description

Fixes #509 - as per suggestion copied in security schema element from lighting API example.
Verified spec is valid using the AsynAPI playground online.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

derberg
derberg previously approved these changes Mar 16, 2021
@derberg
Copy link
Member

derberg commented Mar 16, 2021

@195858 thanks a lot, can you update your branch please

…epo (#510)

* chore: remove everything that is not related to the spec

* fix wording on sponsors

* Get review documents back
@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@derberg derberg merged commit 2351af0 into asyncapi:master Mar 17, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg
Copy link
Member

derberg commented May 24, 2021


@derberg
Copy link
Member

derberg commented May 24, 2021

It is actually not included in the release. This was an unintentional release caused by the release automation initial run. 1.0 version of the spec was released a long time ago. The release mentioned by the bot was removed.

@derberg derberg removed the released label May 24, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0-2021-06-release.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg
Copy link
Member

derberg commented Jun 15, 2021

Not included in release 2.1 yet, 2.1 was mistakenly triggered by our automation.

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue with example correlation-id.yml
4 participants