-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: clarifications on publish and subscribe #521
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5491240
clarifications on publish and subscribe
GeraldLoeffler 23cbd47
Merge pull request #1 from asyncapi/master
GeraldLoeffler 8259374
incorporating Lukasz's feedback
GeraldLoeffler 2814f45
Sticking to produce/consume as much as possible
GeraldLoeffler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello. New here but willing to collaborate.
While reading this, I think "chat application" is quite ambiguous of who's sending and receiving. Following to the Event Driven Architectures docs, it might be clearer to state "publish operation describes messages that are received by the chat application's message broker" and "subscribe operation describes messages that are sent by the chat application's message broker", or around those lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @ alexleonescalera, i agree that chat is not the best example, but this is the example currently used in the spec in this location. I wanted to provide a focused point change to the spec that just provides more clarity on the intent of the
publish
andsubscribe
operations - without making any other changes, such as changing the example used here.