Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: align wording with RFC 2119 #818

Merged
merged 2 commits into from
Sep 9, 2022
Merged

docs: align wording with RFC 2119 #818

merged 2 commits into from
Sep 9, 2022

Conversation

char0n
Copy link
Collaborator

@char0n char0n commented Jul 5, 2022 •
edited by derberg
Loading

This is an editorial change, so sending against master branch.

Refs swagger-api/apidom#1663

More on RFC 2119 -> https://www.rfc-editor.org/rfc/rfc2119

@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@char0n char0n mentioned this pull request Jul 5, 2022
Closed
fmvilas
fmvilas previously approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

smoya
smoya previously approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✍️

@char0n char0n mentioned this pull request Sep 6, 2022
Closed
61 tasks
@char0n
Copy link
Collaborator Author

char0n commented Sep 6, 2022

Hi @dalelane, @derberg. Would you be able to look into this changeset? Thanks!

dalelane
dalelane previously approved these changes Sep 6, 2022
View reviewed changes
@derberg
Copy link
Member

derberg commented Sep 7, 2022

@char0n because of other merges you need to solve some conflicts. Once you do it, you will need to ping all maintainers for review again, sorry

@char0n char0n dismissed stale reviews from dalelane, smoya, and fmvilas via b3f4131 September 7, 2022 15:22
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@char0n
Copy link
Collaborator Author

char0n commented Sep 7, 2022

@smoya @derberg @dalelane @fmvilas can you please re-review after merging changes from master?

@char0n
Copy link
Collaborator Author

char0n commented Sep 9, 2022

@derberg this is an editorial change. Can you merge to master please? Thanks!

@fmvilas
Copy link
Member

fmvilas commented Sep 9, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 5580a9c into asyncapi:master Sep 9, 2022
@fmvilas
Copy link
Member

fmvilas commented Sep 9, 2022

@char0n next time, you can merge it yourself :) Simply type /rtm or /ready-to-merge. Check https://github.com/asyncapi/community/blob/master/CONTRIBUTING.md#automation-around-the-process-of-merging-a-pull-request-pr.

@char0n
Copy link
Collaborator Author

char0n commented Sep 9, 2022

@fmvilas thanks, next time I'll know and bother you guys needlessly ;]

@fmvilas
Copy link
Member

fmvilas commented Sep 9, 2022

Haha! Please do! :trollface:

@char0n
Copy link
Collaborator Author

char0n commented Sep 9, 2022 •
edited
Loading

It sounded like a joke but what I really meant was and will not bother you guys needlessly ;]

@fmvilas
Copy link
Member

fmvilas commented Sep 9, 2022

LOL nooo! I'm disappointed now 😂

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-next-major-spec.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@fmvilas
Copy link
Member

fmvilas commented Sep 22, 2022

Forget about the last comment saying it was released in version 2.5.0-next-major-spec.1. I made a mistake and it created this version but it should actually be 3.0.0-next-major-spec.1. There's a notice in the release. Apologies for the noise.

@derberg derberg mentioned this pull request Sep 28, 2022
Merged
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-next-spec.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg
Copy link
Member

derberg commented Jan 31, 2023

Recent comments about the release from the bot were added by mistake. More details in #899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@dalelane dalelane dalelane approved these changes

@smoya smoya smoya approved these changes

@fmvilas fmvilas fmvilas left review comments

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-major-spec released on @next-spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@char0n @derberg @fmvilas @asyncapi-bot @smoya @dalelane