-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create New page for /tools/ #383
Comments
@iamVP7 can you provide the mockup for the page. I would love to work on this |
I would ask our design contributor extraordinaire, @mcturco for design contributions. 😀👍🏽 Lukasz is awesome, but not in design 😄🙊 |
I could not agree more 🤣 I'm not sure we are at the stage where we can start working on it. @alequetzalli isn't it somehow connected also with new docs page? I mean there will be docs restructuring, and we also want to incorporate docs from tools, and we also want to clean up that some tools are in one location and some are now described in the documentation. A lot of factors that can influence design, @mcturco will ask questions I personally do not have a clear answer to yet. This might be a good candidate for GSoC related task, as it requires discussions with community, and driving it end to end. Don't know 🤷🏼 |
@derberg I was about to say the same thing. Before we can start developing a new page we definitely should discuss what the purpose is if different from the tooling docs and what content we would need to present. Once we have a clear direction and content written, we can begin designing a layout for this (again, if it will be different than the docs) |
I don't think so? I think I see the Docs as a different item than what I understood @iamVP7 was asking to do in this issue. I understand this issue to mean he wanted to know if we could add a page to our website to mention Tools. I guess I thought he opened this issue to ask if we could consolidate all our diverse tool landing pages into a single one. We currently have several individual pages or links to see the tools, but not a single one in the website just briefly summarizing each one. Thus, I thought it would be a question for say, @derberg, @mcturco, or maybe @magicmatatjahu to start a discussion w/ community on the why for this page. That said, if I misunderstood his question, and he was instead asking about having the Tools documented, then yes.... this would be a question for Docs. @iamVP7, can you confirm to us if you were wanting to document the Tools (for AsyncAPI Dev Docs), or if you were asking about making a landing page in our website for all the Tools? |
Got it, he may have forgotten that is what you were referring to! Thank you for clarifying @iamVP7. So if you're proposing a landing page, which is not related to Docs, then I will let @derberg and @mcturco take over this with you. You'll prob work with them to propose your solution to the community and see what the community thinks this page would need. 😀👍🏽 |
Great thank you both for the clarification @alequetzalli @iamVP7 I am understanding the idea now 😄 I think this is a great idea! It definitely will help to have that main |
@mcturco What if it had cards in a grid, and each card represented a tool? |
@alequetzalli yeah I think that's a great idea! Let's do it! |
This issue is about having a single landing page that lists all the tools for AsyncAPI, not only the ones that are maintained by AsyncAPI: We have tools:
We still need pages like:
We should have one single landing page under https://www.asyncapi.com/tools where:
Key - discoverability:
For now I think about simple repo description and topics, might be that long term better to introduce For GSoC participantsThis issue is interesting for GSoC because:
|
@derberg Hmm 🤔 this idea looks fascinating and interesting to me. I am designing the solution in my plan(for To make a Also, later we will have a Regarding filtering of tools in the list and design of the page, it is pretty much straightforward that whenever a user will filter out some tools, those filters will be updated on URLs as well as query |
Hey @derberg, I am willing to continue to work on this issue in Mentorship program. Kindly look on my previous comment and do give your suggestions on how I should improve it. |
@akshatnema Hi!
As I understand that file should be located on the tool's repository side and then in website workflow we should filter all repos with that file and make appropriate logic. Let me know if you understand. Also I prefer
We'd have to hear from Łukasz here, but from what I understand it's a good approach. However, as Łukasz mentioned you need to figure out a way to retrieve this data from the repositories via Github API, this will probably be the hardest part here.
👌🏼 great. |
@magicmatatjahu Yep, it is pretty much difficult to filter out the repos of the specific tools, but what I think is that if we assign specific tags to the repositories having tools, we can make a json fiile according to it. But the condition is, we need to specify tag, category or topics on the repo and each repo should contain exactly one tool in it. Using GitHub GraphQL API, we can extract the tags attached to each repository and store there information in the What I didn't get is the GitHub search that Lukasz mentioned in his previous comment. Some Github search implementation has been made in the cupid repository by Arjun, but I wasn't able to find in it. If you know, kindly send me the reference link of that particular function in the codebase. |
Yep, but it should contain also another info like description, title, maintainer etc. Of course we can also extract that info
Łukasz specified cupid as repo for searching - given repo will have topics and |
@akshatnema I love how far detailed you went with the research. The final solution is not written in stone, like file names and stuff like that. The only strong requirement:
I'm not sure if Super happy to see you engaged here so much. Will advertise it among TSC to make sure it is selected as it is going to be a great addition for the community IMHO |
Hey @derberg, I understood your previous comment and thus, came up with another approach to target this. Do give your views on it. Here it is as follows:
Key points to consider
Waiting for an awesome reply from Lukasz (@derberg). I will be happier if @magicmatatjahu reviews this one as it deals with some code and algorithms as well 🙂. |
I think you guys like to make life difficult for yourselves. When I read about the (Maybe you have the same thing in mind as me, but reading your previous comments I'm confused and don't know if I understood your suggestions correctly) My suggestion:
If someone provides additional topics he/she will be able to do that, but the most important thing is that there should be |
Definitely let us not consider web scrapping as a possible solution. GitHub search allows you to search for specific file in repos and as result, you get a list of repos. Then, afaik API allows you to just grab the content of the specific file, without cloning (something to confirm) tl;dr
|
Yep, we can extract the file contents but not directly through the Github search. What you mentioned in your message are the features used to find files/repos using the Github search bar but we need want it using Github API. I found this in the Github REST API. I think using the above-mentioned API, we can find the file present in the respective repo but need to access the content which is quite hard as the API is not returning the contents of the file directly. We need to discuss regarding this on how to extract the contents of the file using the present JSON. As mentioned by you, if we only need to add |
and enjoy life 🍹 🏖️ the only thing now is I think to agree on the structure of the |
As what I see in the API docs and its schema, we get a
We can call the GET request on this url to get the contents and then convert them into the normal text then. Do confirm if you want to convey this only?
I will try to make one draft schema in the upcoming days but in the format of a javascript object (that's my most preferable way 😅). If you want it in another format, do tell your suggestions. |
sounds good to me
yeah, leave out schema for now, first focus on example JSON objects. Let us agree on the structure, and then to get schema out of it later is easy. Definitely do not start with schema first |
@derberg @magicmatatjahu I'm not sure if you have read my previous comment #383 (comment) or not. Do check that out also and give your opinion. Also, I have some queries:
|
@mcturco as I can see in the design, you have shown the |
@derberg @magicmatatjahu I have a suggestion in my mind right now. We discussed that we will have specified background color and border color for each tag we will be using in dashboard. So, initially, we came up with the idea during the meeting that we create the final JSON in the backend side and then do the assigning of tags with colors in the Frontend side using Fuse and the defined color-schema file. Now, the drawback of this implementation is that every time a user goes to the page, the app will do the same computations to find the tags and their respective colors again and again, for each user. What if we come across a situation where we have enough number of tools and the tags inside them so that this computation take > 0.5 seconds to get executed and show up on the website? It may can slow the loading of the webpage. So, I get here that we are doing the same stuff repeatedly for each website loading. My new idea is, inside each tool element, we can expand the Give your reviews on this whether we should do this on backend side or frontend? |
Good point @akshatnema! What if we do something like this: I am also thinking that it might be better just to leave the avatar out altogether. What do we think about that? |
Ahh, this can be a good way but I can't decide of my own 😅. At the initial, I also didn't came up with the inclusion of tools icon but @derberg suggested me in the meeting to include it. I still ask, whether we should have it? Also, I like the simplified design of right side, and the |
Yeah I am just wondering how many will actually have an avatar, and even then it might look a little cluttered. I would say if we don't need them then we should remove it and go with new card (on the right in the screenshot above) |
@akshatnema Yeah, you should compute colors in the backend. About categories and workflows, please wait for @derberg answer. |
what categories and workflows? 😄 @mcturco yeah, every dev has avatar, but I do agree, getting these in the UI will be hard, especially if there are many maintainers. The only solution is to have |
@derberg Agreed! |
I'm talking about the |
can be done as you do it now, separate workflow, just make sure there is a 10-30min difference between the new workflow schedule and tools, as both end up with PR, so yeah, we just need to make sure they are not created at the same time, as they can create timeouts
just the ones that are in current list on website:
now, I do not have a good idea how we will qualify the ones that are not here yet, like bundler, cupid, optimizer... AsyncAPI documents management? I'm not 100% sure |
The workflow has been designed in the PR. You can review it. |
@akshatnema looks perfect |
Hey @mcturco, can you please update the tool card in the figma according to the right side card in image #383 (comment). After having a discussion with @derberg and @magicmatatjahu #939 (comment), we decided to exclude the field of Regarding the maintainers, we have excluded the maintainers information for the initial release of this implementation. We can later discuss how to add it and handle the maintainers in the Tools card. Also, can you please make the tags for languages and technologies so that I could take their backgroundColor and borderColor to use them in UI? |
@mcturco since we have so many filters in a single dropdown, should we have a |
Summary of Meeting held on 3rd October 2022Participants: @akshatnema @Mayaleeeee Agenda
Meeting Notes
|
Okay.
Thanks for replying.
…On Sat, 27 Aug 2022, 12:09 am Akshat Nema, ***@***.***> wrote:
Is the new page for tools is created or not?
If not, I want to add a new page.
Hey @devarsh10 <https://github.com/devarsh10>, this project idea is part
of my AsyncAPI Mentorship program. So, I've been assigned to make the
/tools/ page. It will be better if you look at other issues to contribute
to the repository. Thanks!
—
Reply to this email directly, view it on GitHub
<#383 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT4MQN3RVR2AXNKLYR4YGFLV3EFPHANCNFSM5EVV7WCA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@derberg As we can see that the functionality to extract the information of tools via GitHub has been added, can we now start to make it public to Tool Owners to make |
@akshatnema I think we first need:
then we can do some promotion on different channels |
Reason/Context
Why we need this improvement?
Creating new index page for tools page.
How will this change help?
We can say what each and every tool does.
What is the motivation?
We are moving pages related to tools under /tools/* so a dedicated index page for tools alone
Description
What changes have to be introduced?
A new page.
Will this be a breaking change?
New page; mostly changes are restricted to new page. If broken it wll be mostly this page.
How could it be implemented/designed?
The text was updated successfully, but these errors were encountered: