Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos in add-server.md #3171

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

mscriven
Copy link
Contributor

Description
There's a couple of typos in the Server reusability md page at https://www.asyncapi.com/docs/concepts/asyncapi-document/add-server#server-reusability

  • Two references missing closing quote
  • Missing colon on components element
    image

Related issue(s)

Fixes #3170

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit 28d7842
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/66d1a71403c8da00089bd3b4
😎 Deploy Preview https://deploy-preview-3171--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Aug 28, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 37
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3171--asyncapi-website.netlify.app/

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thanks!

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU! 😺

@quetzalliwrites quetzalliwrites merged commit b19618f into asyncapi:master Aug 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs Bug 🐞 report]: Fix typos in add-server.md
4 participants