fix: clarify publish/subscribe in StreetLights #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streetlights was incorrect regarding publish/subscribe - and this will likely confuse new users
|
✔️ Deploy Preview for asyncapi-website ready! 🔨 Explore the source changes: 6466bb7 🔍 Inspect the deploy log: https://app.netlify.com/sites/asyncapi-website/deploys/61a6d5c224e2c00007582e3e 😎 Browse the preview: https://deploy-preview-455--asyncapi-website.netlify.app |
nictownsend
changed the title
nictownsend
changed the title
derberg
reviewed
Nov 25, 2021
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
|
Thanks @derberg - really good suggestions! |
derberg
approved these changes
Nov 25, 2021
|
@alequetzalli pingo pingo 😄 |
quetzalliwrites
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
@derberg eeek, thank you for ping! This never showed up in my notifications page somehow 🙈
@nictownsend Thank you so much for helping fix this tutorial!! ❤️✨✨
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streetlights was incorrect regarding publish/subscribe - and this will likely confuse new users
Related issue(s)
asyncapi/spec#521