Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support createDatabaseIfNotExist #162

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Support createDatabaseIfNotExist #162

merged 3 commits into from
Dec 15, 2023

Conversation

mirromutth
Copy link
Contributor

@mirromutth mirromutth commented Dec 13, 2023 •
edited
Loading

Motivation:

See also #158 .

It should be named createDatabaseIfNotExist, the same as JDBC naming.

Modification:

  • Add option to enable createDatabaseIfNotExist
  • Support COM_INIT_DB and database can be initialized after handshake
  • Support sending CREATE DATABASE IF NOT EXISTS statement and retrying COM_INIT_DB after COM_INIT_DB fails for the first time

Result:

Support createDatabaseIfNotExist.

@mirromutth mirromutth added the enhancement New feature or request label Dec 13, 2023
@mirromutth mirromutth marked this pull request as ready for review December 14, 2023 04:57
@mirromutth mirromutth added this to the 1.0.6/0.9.7 milestone Dec 14, 2023
JohnNiang
JohnNiang reviewed Dec 14, 2023
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@mirromutth mirromutth force-pushed the feature/issues-158 branch 2 times, most recently from 6551783 to a96d25b Compare December 14, 2023 07:09
jchrys
jchrys reviewed Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@jchrys jchrys left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a brief description of the newly added feature to the README file?

below are just minor details

Thanks a lot!

src/main/java/io/asyncer/r2dbc/mysql/MySqlConnectionConfiguration.java Outdated Show resolved Hide resolved
src/main/java/io/asyncer/r2dbc/mysql/MySqlConnectionConfiguration.java Outdated Show resolved Hide resolved
src/main/java/io/asyncer/r2dbc/mysql/MySqlConnectionConfiguration.java Outdated Show resolved Hide resolved
src/main/java/io/asyncer/r2dbc/mysql/MySqlConnectionConfiguration.java Outdated Show resolved Hide resolved
@mirromutth
Add option to enable createDatabaseIfNotExist
0a5815c
@mirromutth
Add support for create database if not exist
f22c077 
- Support `InitDbMessage`.
- Support `changeDatabase` in `MySqlConnection`.
- Add integration tests for that.
@mirromutth
Add createDatabaseIfNotExist option to README
551da88
jchrys
jchrys approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mirromutth mirromutth merged commit 4517ade into trunk Dec 15, 2023
10 checks passed
@mirromutth mirromutth deleted the feature/issues-158 branch December 15, 2023 03:44
@jchrys jchrys mentioned this pull request Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang left review comments

@jchrys jchrys jchrys approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.6/0.9.7
Development

Successfully merging this pull request may close these issues.
3 participants
@mirromutth @JohnNiang @jchrys