Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sessionVariables option #221

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Support sessionVariables option #221

merged 2 commits into from
Feb 15, 2024

Conversation

mirromutth
Copy link
Contributor

@mirromutth mirromutth commented Feb 6, 2024 •
edited
Loading

Motivation:

See also #210

Modification:

  • Add session variables splitting method
  • Add an option and a configuration property sessionVariables
  • Set session variable before loading server variables, i.e. SELECT @@transaction_isolation ...

Result:

Support sessionVariables

@mirromutth mirromutth added the enhancement New feature or request label Feb 6, 2024
@mirromutth mirromutth linked an issue Feb 6, 2024 that may be closed by this pull request
[feature]Support sessionVariables configuration properties #210
Closed
@jchrys jchrys added this to the 1.1.1 milestone Feb 6, 2024
@mirromutth mirromutth force-pushed the 210-featuresupport-sessionvariables-configuration-properties branch 5 times, most recently from 86b1387 to 864cc47 Compare February 7, 2024 03:29
@mirromutth mirromutth force-pushed the 210-featuresupport-sessionvariables-configuration-properties branch from 864cc47 to 26d8a3d Compare February 14, 2024 05:05
@mirromutth mirromutth marked this pull request as ready for review February 14, 2024 05:05
@mirromutth mirromutth force-pushed the 210-featuresupport-sessionvariables-configuration-properties branch from 26d8a3d to a655a6f Compare February 14, 2024 06:32
@mirromutth mirromutth mentioned this pull request Feb 14, 2024
Closed
jchrys
jchrys approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jchrys
Copy link
Collaborator

jchrys commented Feb 14, 2024

Missed it but I think need to update the doc as well

@mirromutth
Copy link
Contributor Author

mirromutth commented Feb 15, 2024 •
edited
Loading

I added the doc to wiki page, this should be a good start for more concise docs.

@mirromutth mirromutth force-pushed the 210-featuresupport-sessionvariables-configuration-properties branch from b98c856 to 36e81f4 Compare February 15, 2024 07:55
@mirromutth mirromutth force-pushed the 210-featuresupport-sessionvariables-configuration-properties branch from 36e81f4 to ca1291e Compare February 15, 2024 07:56
@jchrys
Copy link
Collaborator

jchrys commented Feb 15, 2024

I added the doc to wiki page, this should be a good start for more concise docs.

Fantastic! Thank you for kicking things off 👍

@mirromutth mirromutth merged commit 10b055e into trunk Feb 15, 2024
14 checks passed
@mirromutth mirromutth deleted the 210-featuresupport-sessionvariables-configuration-properties branch February 15, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchrys jchrys jchrys approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.

[feature]Support sessionVariables configuration properties
2 participants
@mirromutth @jchrys