Add logging to API methods. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should give the majority of information about what's being sent and received to and from the Robot and is mainly useful for debugging during development. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
This is one of the main reasons we want to have logging, because a "hetznerctl rescue <server>" usually prints nothing until we either have a shell or we timed out waiting for the machine to come up. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
This should make it easier to see which server the log message actually is for. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
This should at least make observed_* actions a bit more visible and we can easily switch between logging levels. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
aszlig
added a commit
that referenced
this pull request
Jul 9, 2014
Although the logging implementation isn't complete, we now at least have logging for observed_* stuff and debug logging for raw robot requests. Conflicts: hetzner/server.py
aszlig
added a commit
to NixOS/nixpkgs
that referenced
this pull request
Dec 4, 2017
New features: * Support for retrieving reverse PTRs. * Support for subnet-ranges. * Add logging (aszlig/hetzner#14). Fixes: * Hide internal methods from the public API. * Fix Python 3 compatibility. * Fix for creating admin accounts with Hetzner's new login site. * Fix __repr__/__str__ issue with some exceptions (aszlig/hetzner#23). * Fix login for RobotWebInterface Changes for the hetznerctl utility: * show: Show subnets * show: Show reverse PTRs * New 'rdns' subcommand for getting/setting/removing reverse-PTRs. * Use 'argparse' instead of 'optparse'. * Add command for managing admin accounts. * New '--debug' flag for printing debugging information. This also fixes NixOS/nixops#778. Tested building against Python 2.7 and Python 3.6. Signed-off-by: aszlig <aszlig@nix.build>
aszlig
added a commit
to NixOS/nixpkgs
that referenced
this pull request
Dec 4, 2017
New features: * Support for retrieving reverse PTRs. * Support for subnet-ranges. * Add logging (aszlig/hetzner#14). Fixes: * Hide internal methods from the public API. * Fix Python 3 compatibility. * Fix for creating admin accounts with Hetzner's new login site. * Fix __repr__/__str__ issue with some exceptions (aszlig/hetzner#23). * Fix login for RobotWebInterface Changes for the hetznerctl utility: * show: Show subnets * show: Show reverse PTRs * New 'rdns' subcommand for getting/setting/removing reverse-PTRs. * Use 'argparse' instead of 'optparse'. * Add command for managing admin accounts. * New '--debug' flag for printing debugging information. This also fixes NixOS/nixops#778. Tested building against Python 2.7 and Python 3.6. Signed-off-by: aszlig <aszlig@nix.build> (cherry picked from commit 6841064) Reason: This unbreaks the NixOps Hetzner target, because the admin sub-account couldn't be created on initial deploy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly implement logging for the API, so especially long-running actions can be debugged more easily.
Also, this should make
hetznerctlmuch more user-friendly because we can use a default log level for the CLI.